x86: msr: propagate errors from smp_call_function_single()

[linux-2.6-omap-h63xx.git] / arch / x86 / lib / msr-on-cpu.c

diff --git a/arch/x86/lib/msr-on-cpu.c b/arch/x86/lib/msr-on-cpu.c
index 7767962f25d34d90f35cb0b7aab64f61b1c454a6..01b868ba82f8c21fd8384a426236e3a315f82dea 100644 (file)
--- a/arch/x86/lib/msr-on-cpu.c
+++ b/arch/x86/lib/msr-on-cpu.c
@@ -26,27 +26,19 @@ static void __rdmsr_safe_on_cpu(void *info)
 static int _rdmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 *l, u32 *h, int safe)
 {
        int err = 0;
-       preempt_disable();
-       if (smp_processor_id() == cpu)
-               if (safe)
-                       err = rdmsr_safe(msr_no, l, h);
-               else
-                       rdmsr(msr_no, *l, *h);
-       else {
-               struct msr_info rv;
-
-               rv.msr_no = msr_no;
-               if (safe) {
-                       smp_call_function_single(cpu, __rdmsr_safe_on_cpu,
-                                                &rv, 0, 1);
-                       err = rv.err;
-               } else {
-                       smp_call_function_single(cpu, __rdmsr_on_cpu, &rv, 0, 1);
-               }
-               *l = rv.l;
-               *h = rv.h;
+       struct msr_info rv;
+
+       rv.msr_no = msr_no;
+       if (safe) {
+               err = smp_call_function_single(cpu, __rdmsr_safe_on_cpu,
+                                              &rv, 1);
+               err = err ? err : rv.err;
+       } else {
+               err = smp_call_function_single(cpu, __rdmsr_on_cpu, &rv, 1);
        }
-       preempt_enable();
+       *l = rv.l;
+       *h = rv.h;
+
        return err;
 }
 
@@ -67,38 +59,30 @@ static void __wrmsr_safe_on_cpu(void *info)
 static int _wrmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 l, u32 h, int safe)
 {
        int err = 0;
-       preempt_disable();
-       if (smp_processor_id() == cpu)
-               if (safe)
-                       err = wrmsr_safe(msr_no, l, h);
-               else
-                       wrmsr(msr_no, l, h);
-       else {
-               struct msr_info rv;
-
-               rv.msr_no = msr_no;
-               rv.l = l;
-               rv.h = h;
-               if (safe) {
-                       smp_call_function_single(cpu, __wrmsr_safe_on_cpu,
-                                                &rv, 0, 1);
-                       err = rv.err;
-               } else {
-                       smp_call_function_single(cpu, __wrmsr_on_cpu, &rv, 0, 1);
-               }
+       struct msr_info rv;
+
+       rv.msr_no = msr_no;
+       rv.l = l;
+       rv.h = h;
+       if (safe) {
+               err = smp_call_function_single(cpu, __wrmsr_safe_on_cpu,
+                                              &rv, 1);
+               err = err ? err : rv.err;
+       } else {
+               err = smp_call_function_single(cpu, __wrmsr_on_cpu, &rv, 1);
        }
-       preempt_enable();
+
        return err;
 }
 
-void wrmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 l, u32 h)
+int wrmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 l, u32 h)
 {
-       _wrmsr_on_cpu(cpu, msr_no, l, h, 0);
+       return _wrmsr_on_cpu(cpu, msr_no, l, h, 0);
 }
 
-void rdmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 *l, u32 *h)
+int rdmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 *l, u32 *h)
 {
-       _rdmsr_on_cpu(cpu, msr_no, l, h, 0);
+       return _rdmsr_on_cpu(cpu, msr_no, l, h, 0);
 }
 
 /* These "safe" variants are slower and should be used when the target MSR