]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - arch/powerpc/mm/numa.c
powerpc: Reserve in bootmem lmb reserved regions that cross NUMA nodes
[linux-2.6-omap-h63xx.git] / arch / powerpc / mm / numa.c
index dc704da363eb77897d392781591bf87ac337a8dd..6cf5c71c431fddc43d33ba920753023d847a991e 100644 (file)
@@ -39,7 +39,6 @@ EXPORT_SYMBOL(numa_cpu_lookup_table);
 EXPORT_SYMBOL(numa_cpumask_lookup_table);
 EXPORT_SYMBOL(node_data);
 
-static bootmem_data_t __initdata plat_node_bdata[MAX_NUMNODES];
 static int min_common_depth;
 static int n_mem_addr_cells, n_mem_size_cells;
 
@@ -90,6 +89,46 @@ static int __cpuinit fake_numa_create_new_node(unsigned long end_pfn,
        return 0;
 }
 
+/*
+ * get_active_region_work_fn - A helper function for get_node_active_region
+ *     Returns datax set to the start_pfn and end_pfn if they contain
+ *     the initial value of datax->start_pfn between them
+ * @start_pfn: start page(inclusive) of region to check
+ * @end_pfn: end page(exclusive) of region to check
+ * @datax: comes in with ->start_pfn set to value to search for and
+ *     goes out with active range if it contains it
+ * Returns 1 if search value is in range else 0
+ */
+static int __init get_active_region_work_fn(unsigned long start_pfn,
+                                       unsigned long end_pfn, void *datax)
+{
+       struct node_active_region *data;
+       data = (struct node_active_region *)datax;
+
+       if (start_pfn <= data->start_pfn && end_pfn > data->start_pfn) {
+               data->start_pfn = start_pfn;
+               data->end_pfn = end_pfn;
+               return 1;
+       }
+       return 0;
+
+}
+
+/*
+ * get_node_active_region - Return active region containing start_pfn
+ * @start_pfn: The page to return the region for.
+ * @node_ar: Returned set to the active region containing start_pfn
+ */
+static void __init get_node_active_region(unsigned long start_pfn,
+                      struct node_active_region *node_ar)
+{
+       int nid = early_pfn_to_nid(start_pfn);
+
+       node_ar->nid = nid;
+       node_ar->start_pfn = start_pfn;
+       work_with_active_regions(nid, get_active_region_work_fn, node_ar);
+}
+
 static void __cpuinit map_cpu_to_node(int cpu, int node)
 {
        numa_cpu_lookup_table[cpu] = node;
@@ -151,6 +190,21 @@ static const int *of_get_associativity(struct device_node *dev)
        return of_get_property(dev, "ibm,associativity", NULL);
 }
 
+/*
+ * Returns the property linux,drconf-usable-memory if
+ * it exists (the property exists only in kexec/kdump kernels,
+ * added by kexec-tools)
+ */
+static const u32 *of_get_usable_memory(struct device_node *memory)
+{
+       const u32 *prop;
+       u32 len;
+       prop = of_get_property(memory, "linux,drconf-usable-memory", &len);
+       if (!prop || len < sizeof(unsigned int))
+               return 0;
+       return prop;
+}
+
 /* Returns nid in the range [0..MAX_NUMNODES-1], or -1 if no useful numa
  * info is found.
  */
@@ -268,6 +322,144 @@ static unsigned long __devinit read_n_cells(int n, const unsigned int **buf)
        return result;
 }
 
+struct of_drconf_cell {
+       u64     base_addr;
+       u32     drc_index;
+       u32     reserved;
+       u32     aa_index;
+       u32     flags;
+};
+
+#define DRCONF_MEM_ASSIGNED    0x00000008
+#define DRCONF_MEM_AI_INVALID  0x00000040
+#define DRCONF_MEM_RESERVED    0x00000080
+
+/*
+ * Read the next lmb list entry from the ibm,dynamic-memory property
+ * and return the information in the provided of_drconf_cell structure.
+ */
+static void read_drconf_cell(struct of_drconf_cell *drmem, const u32 **cellp)
+{
+       const u32 *cp;
+
+       drmem->base_addr = read_n_cells(n_mem_addr_cells, cellp);
+
+       cp = *cellp;
+       drmem->drc_index = cp[0];
+       drmem->reserved = cp[1];
+       drmem->aa_index = cp[2];
+       drmem->flags = cp[3];
+
+       *cellp = cp + 4;
+}
+
+/*
+ * Retreive and validate the ibm,dynamic-memory property of the device tree.
+ *
+ * The layout of the ibm,dynamic-memory property is a number N of lmb
+ * list entries followed by N lmb list entries.  Each lmb list entry
+ * contains information as layed out in the of_drconf_cell struct above.
+ */
+static int of_get_drconf_memory(struct device_node *memory, const u32 **dm)
+{
+       const u32 *prop;
+       u32 len, entries;
+
+       prop = of_get_property(memory, "ibm,dynamic-memory", &len);
+       if (!prop || len < sizeof(unsigned int))
+               return 0;
+
+       entries = *prop++;
+
+       /* Now that we know the number of entries, revalidate the size
+        * of the property read in to ensure we have everything
+        */
+       if (len < (entries * (n_mem_addr_cells + 4) + 1) * sizeof(unsigned int))
+               return 0;
+
+       *dm = prop;
+       return entries;
+}
+
+/*
+ * Retreive and validate the ibm,lmb-size property for drconf memory
+ * from the device tree.
+ */
+static u64 of_get_lmb_size(struct device_node *memory)
+{
+       const u32 *prop;
+       u32 len;
+
+       prop = of_get_property(memory, "ibm,lmb-size", &len);
+       if (!prop || len < sizeof(unsigned int))
+               return 0;
+
+       return read_n_cells(n_mem_size_cells, &prop);
+}
+
+struct assoc_arrays {
+       u32     n_arrays;
+       u32     array_sz;
+       const u32 *arrays;
+};
+
+/*
+ * Retreive and validate the list of associativity arrays for drconf
+ * memory from the ibm,associativity-lookup-arrays property of the
+ * device tree..
+ *
+ * The layout of the ibm,associativity-lookup-arrays property is a number N
+ * indicating the number of associativity arrays, followed by a number M
+ * indicating the size of each associativity array, followed by a list
+ * of N associativity arrays.
+ */
+static int of_get_assoc_arrays(struct device_node *memory,
+                              struct assoc_arrays *aa)
+{
+       const u32 *prop;
+       u32 len;
+
+       prop = of_get_property(memory, "ibm,associativity-lookup-arrays", &len);
+       if (!prop || len < 2 * sizeof(unsigned int))
+               return -1;
+
+       aa->n_arrays = *prop++;
+       aa->array_sz = *prop++;
+
+       /* Now that we know the number of arrrays and size of each array,
+        * revalidate the size of the property read in.
+        */
+       if (len < (aa->n_arrays * aa->array_sz + 2) * sizeof(unsigned int))
+               return -1;
+
+       aa->arrays = prop;
+       return 0;
+}
+
+/*
+ * This is like of_node_to_nid_single() for memory represented in the
+ * ibm,dynamic-reconfiguration-memory node.
+ */
+static int of_drconf_to_nid_single(struct of_drconf_cell *drmem,
+                                  struct assoc_arrays *aa)
+{
+       int default_nid = 0;
+       int nid = default_nid;
+       int index;
+
+       if (min_common_depth > 0 && min_common_depth <= aa->array_sz &&
+           !(drmem->flags & DRCONF_MEM_AI_INVALID) &&
+           drmem->aa_index < aa->n_arrays) {
+               index = drmem->aa_index * aa->array_sz + min_common_depth - 1;
+               nid = aa->arrays[index];
+
+               if (nid == 0xffff || nid >= MAX_NUMNODES)
+                       nid = default_nid;
+       }
+
+       return nid;
+}
+
 /*
  * Figure out to which domain a cpu belongs and stick it there.
  * Return the id of the domain used.
@@ -349,63 +541,86 @@ static unsigned long __init numa_enforce_memory_limit(unsigned long start,
        return lmb_end_of_DRAM() - start;
 }
 
+/*
+ * Reads the counter for a given entry in
+ * linux,drconf-usable-memory property
+ */
+static inline int __init read_usm_ranges(const u32 **usm)
+{
+       /*
+        * For each lmb in ibm,dynamic-memory a corresponding
+        * entry in linux,drconf-usable-memory property contains
+        * a counter followed by that many (base, size) duple.
+        * read the counter from linux,drconf-usable-memory
+        */
+       return read_n_cells(n_mem_size_cells, usm);
+}
+
 /*
  * Extract NUMA information from the ibm,dynamic-reconfiguration-memory
  * node.  This assumes n_mem_{addr,size}_cells have been set.
  */
 static void __init parse_drconf_memory(struct device_node *memory)
 {
-       const unsigned int *lm, *dm, *aa;
-       unsigned int ls, ld, la;
-       unsigned int n, aam, aalen;
-       unsigned long lmb_size, size, start;
-       int nid, default_nid = 0;
-       unsigned int ai, flags;
-
-       lm = of_get_property(memory, "ibm,lmb-size", &ls);
-       dm = of_get_property(memory, "ibm,dynamic-memory", &ld);
-       aa = of_get_property(memory, "ibm,associativity-lookup-arrays", &la);
-       if (!lm || !dm || !aa ||
-           ls < sizeof(unsigned int) || ld < sizeof(unsigned int) ||
-           la < 2 * sizeof(unsigned int))
+       const u32 *dm, *usm;
+       unsigned int n, rc, ranges, is_kexec_kdump = 0;
+       unsigned long lmb_size, base, size, sz;
+       int nid;
+       struct assoc_arrays aa;
+
+       n = of_get_drconf_memory(memory, &dm);
+       if (!n)
                return;
 
-       lmb_size = read_n_cells(n_mem_size_cells, &lm);
-       n = *dm++;              /* number of LMBs */
-       aam = *aa++;            /* number of associativity lists */
-       aalen = *aa++;          /* length of each associativity list */
-       if (ld < (n * (n_mem_addr_cells + 4) + 1) * sizeof(unsigned int) ||
-           la < (aam * aalen + 2) * sizeof(unsigned int))
+       lmb_size = of_get_lmb_size(memory);
+       if (!lmb_size)
                return;
 
+       rc = of_get_assoc_arrays(memory, &aa);
+       if (rc)
+               return;
+
+       /* check if this is a kexec/kdump kernel */
+       usm = of_get_usable_memory(memory);
+       if (usm != NULL)
+               is_kexec_kdump = 1;
+
        for (; n != 0; --n) {
-               start = read_n_cells(n_mem_addr_cells, &dm);
-               ai = dm[2];
-               flags = dm[3];
-               dm += 4;
-               /* 0x80 == reserved, 0x8 = assigned to us */
-               if ((flags & 0x80) || !(flags & 0x8))
-                       continue;
-               nid = default_nid;
-               /* flags & 0x40 means associativity index is invalid */
-               if (min_common_depth > 0 && min_common_depth <= aalen &&
-                   (flags & 0x40) == 0 && ai < aam) {
-                       /* this is like of_node_to_nid_single */
-                       nid = aa[ai * aalen + min_common_depth - 1];
-                       if (nid == 0xffff || nid >= MAX_NUMNODES)
-                               nid = default_nid;
-               }
+               struct of_drconf_cell drmem;
 
-               fake_numa_create_new_node(((start + lmb_size) >> PAGE_SHIFT),
-                                               &nid);
-               node_set_online(nid);
+               read_drconf_cell(&drmem, &dm);
 
-               size = numa_enforce_memory_limit(start, lmb_size);
-               if (!size)
+               /* skip this block if the reserved bit is set in flags (0x80)
+                  or if the block is not assigned to this partition (0x8) */
+               if ((drmem.flags & DRCONF_MEM_RESERVED)
+                   || !(drmem.flags & DRCONF_MEM_ASSIGNED))
                        continue;
 
-               add_active_range(nid, start >> PAGE_SHIFT,
-                                (start >> PAGE_SHIFT) + (size >> PAGE_SHIFT));
+               base = drmem.base_addr;
+               size = lmb_size;
+               ranges = 1;
+
+               if (is_kexec_kdump) {
+                       ranges = read_usm_ranges(&usm);
+                       if (!ranges) /* there are no (base, size) duple */
+                               continue;
+               }
+               do {
+                       if (is_kexec_kdump) {
+                               base = read_n_cells(n_mem_addr_cells, &usm);
+                               size = read_n_cells(n_mem_size_cells, &usm);
+                       }
+                       nid = of_drconf_to_nid_single(&drmem, &aa);
+                       fake_numa_create_new_node(
+                               ((base + size) >> PAGE_SHIFT),
+                                          &nid);
+                       node_set_online(nid);
+                       sz = numa_enforce_memory_limit(base, size);
+                       if (sz)
+                               add_active_range(nid, base >> PAGE_SHIFT,
+                                                (base >> PAGE_SHIFT)
+                                                + (sz >> PAGE_SHIFT));
+               } while (--ranges);
        }
 }
 
@@ -685,7 +900,7 @@ void __init do_init_bootmem(void)
                dbg("node %d\n", nid);
                dbg("NODE_DATA() = %p\n", NODE_DATA(nid));
 
-               NODE_DATA(nid)->bdata = &plat_node_bdata[nid];
+               NODE_DATA(nid)->bdata = &bootmem_node_data[nid];
                NODE_DATA(nid)->node_start_pfn = start_pfn;
                NODE_DATA(nid)->node_spanned_pages = end_pfn - start_pfn;
 
@@ -707,38 +922,50 @@ void __init do_init_bootmem(void)
                                  start_pfn, end_pfn);
 
                free_bootmem_with_active_regions(nid, end_pfn);
+       }
 
-               /* Mark reserved regions on this node */
-               for (i = 0; i < lmb.reserved.cnt; i++) {
-                       unsigned long physbase = lmb.reserved.region[i].base;
-                       unsigned long size = lmb.reserved.region[i].size;
-                       unsigned long start_paddr = start_pfn << PAGE_SHIFT;
-                       unsigned long end_paddr = end_pfn << PAGE_SHIFT;
-
-                       if (early_pfn_to_nid(physbase >> PAGE_SHIFT) != nid &&
-                           early_pfn_to_nid((physbase+size-1) >> PAGE_SHIFT) != nid)
-                               continue;
-
-                       if (physbase < end_paddr &&
-                           (physbase+size) > start_paddr) {
-                               /* overlaps */
-                               if (physbase < start_paddr) {
-                                       size -= start_paddr - physbase;
-                                       physbase = start_paddr;
-                               }
-
-                               if (size > end_paddr - physbase)
-                                       size = end_paddr - physbase;
-
-                               dbg("reserve_bootmem %lx %lx\n", physbase,
-                                   size);
-                               reserve_bootmem_node(NODE_DATA(nid), physbase,
-                                                    size, BOOTMEM_DEFAULT);
-                       }
+       /* Mark reserved regions */
+       for (i = 0; i < lmb.reserved.cnt; i++) {
+               unsigned long physbase = lmb.reserved.region[i].base;
+               unsigned long size = lmb.reserved.region[i].size;
+               unsigned long start_pfn = physbase >> PAGE_SHIFT;
+               unsigned long end_pfn = ((physbase + size) >> PAGE_SHIFT);
+               struct node_active_region node_ar;
+
+               get_node_active_region(start_pfn, &node_ar);
+               while (start_pfn < end_pfn) {
+                       /*
+                        * if reserved region extends past active region
+                        * then trim size to active region
+                        */
+                       if (end_pfn > node_ar.end_pfn)
+                               size = (node_ar.end_pfn << PAGE_SHIFT)
+                                       - (start_pfn << PAGE_SHIFT);
+                       dbg("reserve_bootmem %lx %lx nid=%d\n", physbase, size,
+                               node_ar.nid);
+                       reserve_bootmem_node(NODE_DATA(node_ar.nid), physbase,
+                                               size, BOOTMEM_DEFAULT);
+                       /*
+                        * if reserved region is contained in the active region
+                        * then done.
+                        */
+                       if (end_pfn <= node_ar.end_pfn)
+                               break;
+
+                       /*
+                        * reserved region extends past the active region
+                        *   get next active region that contains this
+                        *   reserved region
+                        */
+                       start_pfn = node_ar.end_pfn;
+                       physbase = start_pfn << PAGE_SHIFT;
+                       get_node_active_region(start_pfn, &node_ar);
                }
 
-               sparse_memory_present_with_active_regions(nid);
        }
+
+       for_each_online_node(nid)
+               sparse_memory_present_with_active_regions(nid);
 }
 
 void __init paging_init(void)
@@ -769,6 +996,79 @@ static int __init early_numa(char *p)
 early_param("numa", early_numa);
 
 #ifdef CONFIG_MEMORY_HOTPLUG
+/*
+ * Validate the node associated with the memory section we are
+ * trying to add.
+ */
+int valid_hot_add_scn(int *nid, unsigned long start, u32 lmb_size,
+                     unsigned long scn_addr)
+{
+       nodemask_t nodes;
+
+       if (*nid < 0 || !node_online(*nid))
+               *nid = any_online_node(NODE_MASK_ALL);
+
+       if ((scn_addr >= start) && (scn_addr < (start + lmb_size))) {
+               nodes_setall(nodes);
+               while (NODE_DATA(*nid)->node_spanned_pages == 0) {
+                       node_clear(*nid, nodes);
+                       *nid = any_online_node(nodes);
+               }
+
+               return 1;
+       }
+
+       return 0;
+}
+
+/*
+ * Find the node associated with a hot added memory section represented
+ * by the ibm,dynamic-reconfiguration-memory node.
+ */
+static int hot_add_drconf_scn_to_nid(struct device_node *memory,
+                                    unsigned long scn_addr)
+{
+       const u32 *dm;
+       unsigned int n, rc;
+       unsigned long lmb_size;
+       int default_nid = any_online_node(NODE_MASK_ALL);
+       int nid;
+       struct assoc_arrays aa;
+
+       n = of_get_drconf_memory(memory, &dm);
+       if (!n)
+               return default_nid;;
+
+       lmb_size = of_get_lmb_size(memory);
+       if (!lmb_size)
+               return default_nid;
+
+       rc = of_get_assoc_arrays(memory, &aa);
+       if (rc)
+               return default_nid;
+
+       for (; n != 0; --n) {
+               struct of_drconf_cell drmem;
+
+               read_drconf_cell(&drmem, &dm);
+
+               /* skip this block if it is reserved or not assigned to
+                * this partition */
+               if ((drmem.flags & DRCONF_MEM_RESERVED)
+                   || !(drmem.flags & DRCONF_MEM_ASSIGNED))
+                       continue;
+
+               nid = of_drconf_to_nid_single(&drmem, &aa);
+
+               if (valid_hot_add_scn(&nid, drmem.base_addr, lmb_size,
+                                     scn_addr))
+                       return nid;
+       }
+
+       BUG();  /* section address should be found above */
+       return 0;
+}
+
 /*
  * Find the node associated with a hot added memory section.  Section
  * corresponds to a SPARSEMEM section, not an LMB.  It is assumed that
@@ -777,12 +1077,17 @@ early_param("numa", early_numa);
 int hot_add_scn_to_nid(unsigned long scn_addr)
 {
        struct device_node *memory = NULL;
-       nodemask_t nodes;
-       int default_nid = any_online_node(NODE_MASK_ALL);
        int nid;
 
        if (!numa_enabled || (min_common_depth < 0))
-               return default_nid;
+               return any_online_node(NODE_MASK_ALL);
+
+       memory = of_find_node_by_path("/ibm,dynamic-reconfiguration-memory");
+       if (memory) {
+               nid = hot_add_drconf_scn_to_nid(memory, scn_addr);
+               of_node_put(memory);
+               return nid;
+       }
 
        while ((memory = of_find_node_by_type(memory, "memory")) != NULL) {
                unsigned long start, size;
@@ -801,13 +1106,9 @@ ha_new_range:
                size = read_n_cells(n_mem_size_cells, &memcell_buf);
                nid = of_node_to_nid_single(memory);
 
-               /* Domains not present at boot default to 0 */
-               if (nid < 0 || !node_online(nid))
-                       nid = default_nid;
-
-               if ((scn_addr >= start) && (scn_addr < (start + size))) {
+               if (valid_hot_add_scn(&nid, start, size, scn_addr)) {
                        of_node_put(memory);
-                       goto got_nid;
+                       return nid;
                }
 
                if (--ranges)           /* process all ranges in cell */
@@ -815,14 +1116,5 @@ ha_new_range:
        }
        BUG();  /* section address should be found above */
        return 0;
-
-       /* Temporary code to ensure that returned node is not empty */
-got_nid:
-       nodes_setall(nodes);
-       while (NODE_DATA(nid)->node_spanned_pages == 0) {
-               node_clear(nid, nodes);
-               nid = any_online_node(nodes);
-       }
-       return nid;
 }
 #endif /* CONFIG_MEMORY_HOTPLUG */