2 * Copyright (C) 1994-1998 Linus Torvalds & authors (see below)
3 * Copyright (C) 2005, 2007 Bartlomiej Zolnierkiewicz
7 * Mostly written by Mark Lord <mlord@pobox.com>
8 * and Gadi Oxman <gadio@netvision.net.il>
9 * and Andre Hedrick <andre@linux-ide.org>
11 * See linux/MAINTAINERS for address of current maintainer.
13 * This is the IDE probe module, as evolved from hd.c and ide.c.
15 * -- increase WAIT_PIDENTIFY to avoid CD-ROM locking at boot
19 #include <linux/module.h>
20 #include <linux/types.h>
21 #include <linux/string.h>
22 #include <linux/kernel.h>
23 #include <linux/timer.h>
25 #include <linux/interrupt.h>
26 #include <linux/major.h>
27 #include <linux/errno.h>
28 #include <linux/genhd.h>
29 #include <linux/slab.h>
30 #include <linux/delay.h>
31 #include <linux/ide.h>
32 #include <linux/spinlock.h>
33 #include <linux/kmod.h>
34 #include <linux/pci.h>
35 #include <linux/scatterlist.h>
37 #include <asm/byteorder.h>
39 #include <asm/uaccess.h>
43 * generic_id - add a generic drive id
44 * @drive: drive to make an ID block for
46 * Add a fake id field to the drive we are passed. This allows
47 * use to skip a ton of NULL checks (which people always miss)
48 * and make drive properties unconditional outside of this file
51 static void generic_id(ide_drive_t *drive)
55 id[ATA_ID_CUR_CYLS] = id[ATA_ID_CYLS] = drive->cyl;
56 id[ATA_ID_CUR_HEADS] = id[ATA_ID_HEADS] = drive->head;
57 id[ATA_ID_CUR_SECTORS] = id[ATA_ID_SECTORS] = drive->sect;
60 static void ide_disk_init_chs(ide_drive_t *drive)
64 /* Extract geometry if we did not already have one for the drive */
65 if (!drive->cyl || !drive->head || !drive->sect) {
66 drive->cyl = drive->bios_cyl = id[ATA_ID_CYLS];
67 drive->head = drive->bios_head = id[ATA_ID_HEADS];
68 drive->sect = drive->bios_sect = id[ATA_ID_SECTORS];
71 /* Handle logical geometry translation by the drive */
72 if (ata_id_current_chs_valid(id)) {
73 drive->cyl = id[ATA_ID_CUR_CYLS];
74 drive->head = id[ATA_ID_CUR_HEADS];
75 drive->sect = id[ATA_ID_CUR_SECTORS];
78 /* Use physical geometry if what we have still makes no sense */
79 if (drive->head > 16 && id[ATA_ID_HEADS] && id[ATA_ID_HEADS] <= 16) {
80 drive->cyl = id[ATA_ID_CYLS];
81 drive->head = id[ATA_ID_HEADS];
82 drive->sect = id[ATA_ID_SECTORS];
86 static void ide_disk_init_mult_count(ide_drive_t *drive)
89 u8 max_multsect = id[ATA_ID_MAX_MULTSECT] & 0xff;
92 if ((max_multsect / 2) > 1)
93 id[ATA_ID_MULTSECT] = max_multsect | 0x100;
95 id[ATA_ID_MULTSECT] &= ~0x1ff;
97 drive->mult_req = id[ATA_ID_MULTSECT] & 0xff;
100 drive->special.b.set_multmode = 1;
105 * do_identify - identify a drive
106 * @drive: drive to identify
109 * Called when we have issued a drive identify command to
110 * read and parse the results. This function is run with
111 * interrupts disabled.
114 static inline void do_identify (ide_drive_t *drive, u8 cmd)
116 ide_hwif_t *hwif = HWIF(drive);
118 char *m = (char *)&id[ATA_ID_PROD];
121 /* read 512 bytes of id info */
122 hwif->tp_ops->input_data(drive, NULL, id, SECTOR_SIZE);
127 printk(KERN_INFO "%s: dumping identify data\n", drive->name);
128 ide_dump_identify((u8 *)id);
133 * ATA_CMD_ID_ATA returns little-endian info,
134 * ATA_CMD_ID_ATAPI *usually* returns little-endian info.
136 if (cmd == ATA_CMD_ID_ATAPI) {
137 if ((m[0] == 'N' && m[1] == 'E') || /* NEC */
138 (m[0] == 'F' && m[1] == 'X') || /* Mitsumi */
139 (m[0] == 'P' && m[1] == 'i')) /* Pioneer */
140 /* Vertos drives may still be weird */
144 ide_fixstring(m, ATA_ID_PROD_LEN, bswap);
145 ide_fixstring((char *)&id[ATA_ID_FW_REV], ATA_ID_FW_REV_LEN, bswap);
146 ide_fixstring((char *)&id[ATA_ID_SERNO], ATA_ID_SERNO_LEN, bswap);
148 /* we depend on this a lot! */
149 m[ATA_ID_PROD_LEN - 1] = '\0';
151 if (strstr(m, "E X A B Y T E N E S T"))
154 printk(KERN_INFO "%s: %s, ", drive->name, m);
160 * Check for an ATAPI device
162 if (cmd == ATA_CMD_ID_ATAPI) {
163 u8 type = (id[ATA_ID_CONFIG] >> 8) & 0x1f;
165 printk(KERN_CONT "ATAPI ");
168 if (!strstr(m, "CD-ROM")) {
169 if (!strstr(m, "oppy") &&
170 !strstr(m, "poyp") &&
172 printk(KERN_CONT "cdrom or floppy?, assuming ");
173 if (drive->media != ide_cdrom) {
174 printk(KERN_CONT "FLOPPY");
175 drive->removable = 1;
179 /* Early cdrom models used zero */
182 drive->removable = 1;
184 /* kludge for Apple PowerBook internal zip */
185 if (!strstr(m, "CD-ROM") && strstr(m, "ZIP")) {
186 printk(KERN_CONT "FLOPPY");
191 printk(KERN_CONT "CD/DVD-ROM");
194 printk(KERN_CONT "TAPE");
197 printk(KERN_CONT "OPTICAL");
198 drive->removable = 1;
201 printk(KERN_CONT "UNKNOWN (type %d)", type);
204 printk(KERN_CONT " drive\n");
206 /* an ATAPI device ignores DRDY */
207 drive->ready_stat = 0;
212 * Not an ATAPI device: looks like a "regular" hard disk
216 * 0x848a = CompactFlash device
217 * These are *not* removable in Linux definition of the term
219 if (id[ATA_ID_CONFIG] != 0x848a && (id[ATA_ID_CONFIG] & (1 << 7)))
220 drive->removable = 1;
222 drive->media = ide_disk;
224 printk(KERN_CONT "%s DISK drive\n",
225 (id[ATA_ID_CONFIG] == 0x848a) ? "CFA" : "ATA");
236 * actual_try_to_identify - send ata/atapi identify
237 * @drive: drive to identify
238 * @cmd: command to use
240 * try_to_identify() sends an ATA(PI) IDENTIFY request to a drive
241 * and waits for a response. It also monitors irqs while this is
242 * happening, in hope of automatically determining which one is
243 * being used by the interface.
245 * Returns: 0 device was identified
246 * 1 device timed-out (no response to identify request)
247 * 2 device aborted the command (refused to identify itself)
250 static int actual_try_to_identify (ide_drive_t *drive, u8 cmd)
252 ide_hwif_t *hwif = HWIF(drive);
253 struct ide_io_ports *io_ports = &hwif->io_ports;
254 const struct ide_tp_ops *tp_ops = hwif->tp_ops;
255 int use_altstatus = 0, rc;
256 unsigned long timeout;
259 /* take a deep breath */
262 if (io_ports->ctl_addr) {
263 a = tp_ops->read_altstatus(hwif);
264 s = tp_ops->read_status(hwif);
265 if ((a ^ s) & ~ATA_IDX)
266 /* ancient Seagate drives, broken interfaces */
267 printk(KERN_INFO "%s: probing with STATUS(0x%02x) "
268 "instead of ALTSTATUS(0x%02x)\n",
271 /* use non-intrusive polling */
275 /* set features register for atapi
276 * identify command to be sure of reply
278 if (cmd == ATA_CMD_ID_ATAPI) {
281 memset(&task, 0, sizeof(task));
282 /* disable DMA & overlap */
283 task.tf_flags = IDE_TFLAG_OUT_FEATURE;
285 tp_ops->tf_load(drive, &task);
288 /* ask drive for ID */
289 tp_ops->exec_command(hwif, cmd);
291 timeout = ((cmd == ATA_CMD_ID_ATA) ? WAIT_WORSTCASE : WAIT_PIDENTIFY) / 2;
293 if (ide_busy_sleep(hwif, timeout, use_altstatus))
296 /* wait for IRQ and ATA_DRQ */
298 s = tp_ops->read_status(hwif);
300 if (OK_STAT(s, ATA_DRQ, BAD_R_STAT)) {
303 /* local CPU only; some systems need this */
304 local_irq_save(flags);
305 /* drive returned ID */
306 do_identify(drive, cmd);
307 /* drive responded with ID */
309 /* clear drive IRQ */
310 (void)tp_ops->read_status(hwif);
311 local_irq_restore(flags);
313 /* drive refused ID */
320 * try_to_identify - try to identify a drive
321 * @drive: drive to probe
322 * @cmd: command to use
324 * Issue the identify command and then do IRQ probing to
325 * complete the identification when needed by finding the
326 * IRQ the drive is attached to
329 static int try_to_identify (ide_drive_t *drive, u8 cmd)
331 ide_hwif_t *hwif = HWIF(drive);
332 const struct ide_tp_ops *tp_ops = hwif->tp_ops;
335 unsigned long cookie = 0;
338 * Disable device irq unless we need to
339 * probe for it. Otherwise we'll get spurious
340 * interrupts during the identify-phase that
341 * the irq handler isn't expecting.
343 if (hwif->io_ports.ctl_addr) {
346 cookie = probe_irq_on();
348 tp_ops->set_irq(hwif, autoprobe);
351 retval = actual_try_to_identify(drive, cmd);
356 tp_ops->set_irq(hwif, 0);
357 /* clear drive IRQ */
358 (void)tp_ops->read_status(hwif);
360 irq = probe_irq_off(cookie);
365 /* Mmmm.. multiple IRQs..
366 * don't know which was ours
368 printk(KERN_ERR "%s: IRQ probe failed (0x%lx)\n",
369 drive->name, cookie);
376 int ide_busy_sleep(ide_hwif_t *hwif, unsigned long timeout, int altstatus)
383 msleep(50); /* give drive a breather */
384 stat = altstatus ? hwif->tp_ops->read_altstatus(hwif)
385 : hwif->tp_ops->read_status(hwif);
386 if ((stat & ATA_BUSY) == 0)
388 } while (time_before(jiffies, timeout));
390 return 1; /* drive timed-out */
393 static u8 ide_read_device(ide_drive_t *drive)
397 memset(&task, 0, sizeof(task));
398 task.tf_flags = IDE_TFLAG_IN_DEVICE;
400 drive->hwif->tp_ops->tf_read(drive, &task);
402 return task.tf.device;
406 * do_probe - probe an IDE device
407 * @drive: drive to probe
408 * @cmd: command to use
410 * do_probe() has the difficult job of finding a drive if it exists,
411 * without getting hung up if it doesn't exist, without trampling on
412 * ethernet cards, and without leaving any IRQs dangling to haunt us later.
414 * If a drive is "known" to exist (from CMOS or kernel parameters),
415 * but does not respond right away, the probe will "hang in there"
416 * for the maximum wait time (about 30 seconds), otherwise it will
417 * exit much more quickly.
419 * Returns: 0 device was identified
420 * 1 device timed-out (no response to identify request)
421 * 2 device aborted the command (refused to identify itself)
422 * 3 bad status from device (possible for ATAPI drives)
423 * 4 probe was not attempted because failure was obvious
426 static int do_probe (ide_drive_t *drive, u8 cmd)
428 ide_hwif_t *hwif = HWIF(drive);
429 const struct ide_tp_ops *tp_ops = hwif->tp_ops;
433 if (drive->present) {
434 /* avoid waiting for inappropriate probes */
435 if (drive->media != ide_disk && cmd == ATA_CMD_ID_ATA)
439 printk(KERN_INFO "probing for %s: present=%d, media=%d, probetype=%s\n",
440 drive->name, drive->present, drive->media,
441 (cmd == ATA_CMD_ID_ATA) ? "ATA" : "ATAPI");
444 /* needed for some systems
445 * (e.g. crw9624 as drive0 with disk as slave)
451 if (ide_read_device(drive) != drive->select.all && !drive->present) {
452 if (drive->select.b.unit != 0) {
453 /* exit with drive0 selected */
454 SELECT_DRIVE(&hwif->drives[0]);
455 /* allow ATA_BUSY to assert & clear */
458 /* no i/f present: mmm.. this should be a 4 -ml */
462 stat = tp_ops->read_status(hwif);
464 if (OK_STAT(stat, ATA_DRDY, ATA_BUSY) ||
465 drive->present || cmd == ATA_CMD_ID_ATAPI) {
466 /* send cmd and wait */
467 if ((rc = try_to_identify(drive, cmd))) {
468 /* failed: try again */
469 rc = try_to_identify(drive,cmd);
472 stat = tp_ops->read_status(hwif);
474 if (stat == (ATA_BUSY | ATA_DRDY))
477 if (rc == 1 && cmd == ATA_CMD_ID_ATAPI) {
478 printk(KERN_ERR "%s: no response (status = 0x%02x), "
479 "resetting drive\n", drive->name, stat);
483 tp_ops->exec_command(hwif, ATA_CMD_DEV_RESET);
484 (void)ide_busy_sleep(hwif, WAIT_WORSTCASE, 0);
485 rc = try_to_identify(drive, cmd);
488 /* ensure drive IRQ is clear */
489 stat = tp_ops->read_status(hwif);
492 printk(KERN_ERR "%s: no response (status = 0x%02x)\n",
495 /* not present or maybe ATAPI */
498 if (drive->select.b.unit != 0) {
499 /* exit with drive0 selected */
500 SELECT_DRIVE(&hwif->drives[0]);
502 /* ensure drive irq is clear */
503 (void)tp_ops->read_status(hwif);
511 static void enable_nest (ide_drive_t *drive)
513 ide_hwif_t *hwif = HWIF(drive);
514 const struct ide_tp_ops *tp_ops = hwif->tp_ops;
517 printk(KERN_INFO "%s: enabling %s -- ",
518 hwif->name, (char *)&drive->id[ATA_ID_PROD]);
522 tp_ops->exec_command(hwif, ATA_EXABYTE_ENABLE_NEST);
524 if (ide_busy_sleep(hwif, WAIT_WORSTCASE, 0)) {
525 printk(KERN_CONT "failed (timeout)\n");
531 stat = tp_ops->read_status(hwif);
533 if (!OK_STAT(stat, 0, BAD_STAT))
534 printk(KERN_CONT "failed (status = 0x%02x)\n", stat);
536 printk(KERN_CONT "success\n");
540 * probe_for_drives - upper level drive probe
541 * @drive: drive to probe for
543 * probe_for_drive() tests for existence of a given drive using do_probe()
544 * and presents things to the user as needed.
546 * Returns: 0 no device was found
547 * 1 device was found (note: drive->present might
551 static inline u8 probe_for_drive (ide_drive_t *drive)
556 * In order to keep things simple we have an id
557 * block for all drives at all times. If the device
558 * is pre ATA or refuses ATA/ATAPI identify we
559 * will add faked data to this.
561 * Also note that 0 everywhere means "can't do X"
564 drive->id = kzalloc(SECTOR_WORDS *4, GFP_KERNEL);
566 if(drive->id == NULL)
568 printk(KERN_ERR "ide: out of memory for id data.\n");
572 m = (char *)&drive->id[ATA_ID_PROD];
573 strcpy(m, "UNKNOWN");
576 if (!drive->noprobe) {
578 /* if !(success||timed-out) */
579 if (do_probe(drive, ATA_CMD_ID_ATA) >= 2)
580 /* look for ATAPI device */
581 (void)do_probe(drive, ATA_CMD_ID_ATAPI);
584 /* drive not found */
587 if (strstr(m, "E X A B Y T E N E S T")) {
592 /* identification failed? */
593 if (!drive->id_read) {
594 if (drive->media == ide_disk) {
595 printk(KERN_INFO "%s: non-IDE drive, CHS=%d/%d/%d\n",
596 drive->name, drive->cyl,
597 drive->head, drive->sect);
598 } else if (drive->media == ide_cdrom) {
599 printk(KERN_INFO "%s: ATAPI cdrom (?)\n", drive->name);
602 printk(KERN_WARNING "%s: Unknown device on bus refused identification. Ignoring.\n", drive->name);
606 /* drive was found */
610 /* The drive wasn't being helpful. Add generic info only */
611 if (drive->id_read == 0) {
616 if (drive->media == ide_disk) {
617 ide_disk_init_chs(drive);
618 ide_disk_init_mult_count(drive);
621 return drive->present;
624 static void hwif_release_dev(struct device *dev)
626 ide_hwif_t *hwif = container_of(dev, ide_hwif_t, gendev);
628 complete(&hwif->gendev_rel_comp);
631 static int ide_register_port(ide_hwif_t *hwif)
635 /* register with global device tree */
636 strlcpy(hwif->gendev.bus_id,hwif->name,BUS_ID_SIZE);
637 hwif->gendev.driver_data = hwif;
638 if (hwif->gendev.parent == NULL) {
640 hwif->gendev.parent = hwif->dev;
642 /* Would like to do = &device_legacy */
643 hwif->gendev.parent = NULL;
645 hwif->gendev.release = hwif_release_dev;
646 ret = device_register(&hwif->gendev);
648 printk(KERN_WARNING "IDE: %s: device_register error: %d\n",
653 hwif->portdev = device_create_drvdata(ide_port_class, &hwif->gendev,
654 MKDEV(0, 0), hwif, hwif->name);
655 if (IS_ERR(hwif->portdev)) {
656 ret = PTR_ERR(hwif->portdev);
657 device_unregister(&hwif->gendev);
664 * ide_port_wait_ready - wait for port to become ready
667 * This is needed on some PPCs and a bunch of BIOS-less embedded
668 * platforms. Typical cases are:
670 * - The firmware hard reset the disk before booting the kernel,
671 * the drive is still doing it's poweron-reset sequence, that
672 * can take up to 30 seconds.
674 * - The firmware does nothing (or no firmware), the device is
675 * still in POST state (same as above actually).
677 * - Some CD/DVD/Writer combo drives tend to drive the bus during
678 * their reset sequence even when they are non-selected slave
679 * devices, thus preventing discovery of the main HD.
681 * Doing this wait-for-non-busy should not harm any existing
682 * configuration and fix some issues like the above.
686 * Returns 0 on success, error code (< 0) otherwise.
689 static int ide_port_wait_ready(ide_hwif_t *hwif)
693 printk(KERN_DEBUG "Probing IDE interface %s...\n", hwif->name);
695 /* Let HW settle down a bit from whatever init state we
699 /* Wait for BSY bit to go away, spec timeout is 30 seconds,
700 * I know of at least one disk who takes 31 seconds, I use 35
703 rc = ide_wait_not_busy(hwif, 35000);
707 /* Now make sure both master & slave are ready */
708 for (unit = 0; unit < MAX_DRIVES; unit++) {
709 ide_drive_t *drive = &hwif->drives[unit];
711 /* Ignore disks that we will not probe for later. */
712 if (!drive->noprobe || drive->present) {
714 hwif->tp_ops->set_irq(hwif, 1);
716 rc = ide_wait_not_busy(hwif, 35000);
720 printk(KERN_DEBUG "%s: ide_wait_not_busy() skipped\n",
724 /* Exit function with master reselected (let's be sane) */
726 SELECT_DRIVE(&hwif->drives[0]);
732 * ide_undecoded_slave - look for bad CF adapters
733 * @dev1: slave device
735 * Analyse the drives on the interface and attempt to decide if we
736 * have the same drive viewed twice. This occurs with crap CF adapters
737 * and PCMCIA sometimes.
740 void ide_undecoded_slave(ide_drive_t *dev1)
742 ide_drive_t *dev0 = &dev1->hwif->drives[0];
744 if ((dev1->dn & 1) == 0 || dev0->present == 0)
747 /* If the models don't match they are not the same product */
748 if (strcmp((char *)&dev0->id[ATA_ID_PROD],
749 (char *)&dev1->id[ATA_ID_PROD]))
752 /* Serial numbers do not match */
753 if (strncmp((char *)&dev0->id[ATA_ID_SERNO],
754 (char *)&dev1->id[ATA_ID_SERNO], ATA_ID_SERNO_LEN))
757 /* No serial number, thankfully very rare for CF */
758 if (*(char *)&dev0->id[ATA_ID_SERNO] == 0)
761 /* Appears to be an IDE flash adapter with decode bugs */
762 printk(KERN_WARNING "ide-probe: ignoring undecoded slave\n");
767 EXPORT_SYMBOL_GPL(ide_undecoded_slave);
769 static int ide_probe_port(ide_hwif_t *hwif)
773 int unit, rc = -ENODEV;
775 BUG_ON(hwif->present);
777 if (hwif->drives[0].noprobe && hwif->drives[1].noprobe)
781 * We must always disable IRQ, as probe_for_drive will assert IRQ, but
782 * we'll install our IRQ driver much later...
786 disable_irq(hwif->irq);
788 local_irq_set(flags);
790 if (ide_port_wait_ready(hwif) == -EBUSY)
791 printk(KERN_DEBUG "%s: Wait for ready failed before probe !\n", hwif->name);
794 * Second drive should only exist if first drive was found,
795 * but a lot of cdrom drives are configured as single slaves.
797 for (unit = 0; unit < MAX_DRIVES; ++unit) {
798 ide_drive_t *drive = &hwif->drives[unit];
799 drive->dn = (hwif->channel ? 2 : 0) + unit;
800 (void) probe_for_drive(drive);
805 local_irq_restore(flags);
808 * Use cached IRQ number. It might be (and is...) changed by probe
817 static void ide_port_tune_devices(ide_hwif_t *hwif)
819 const struct ide_port_ops *port_ops = hwif->port_ops;
822 for (unit = 0; unit < MAX_DRIVES; unit++) {
823 ide_drive_t *drive = &hwif->drives[unit];
825 if (drive->present && port_ops && port_ops->quirkproc)
826 port_ops->quirkproc(drive);
829 for (unit = 0; unit < MAX_DRIVES; ++unit) {
830 ide_drive_t *drive = &hwif->drives[unit];
832 if (drive->present) {
833 ide_set_max_pio(drive);
842 for (unit = 0; unit < MAX_DRIVES; ++unit) {
843 ide_drive_t *drive = &hwif->drives[unit];
845 if (hwif->host_flags & IDE_HFLAG_NO_IO_32BIT)
846 drive->no_io_32bit = 1;
848 drive->no_io_32bit = drive->id[ATA_ID_DWORD_IO] ? 1 : 0;
854 * save_match() is used to simplify logic in init_irq() below.
856 * A loophole here is that we may not know about a particular
857 * hwif's irq until after that hwif is actually probed/initialized..
858 * This could be a problem for the case where an hwif is on a
859 * dual interface that requires serialization (eg. cmd640) and another
860 * hwif using one of the same irqs is initialized beforehand.
862 * This routine detects and reports such situations, but does not fix them.
864 static void save_match(ide_hwif_t *hwif, ide_hwif_t *new, ide_hwif_t **match)
866 ide_hwif_t *m = *match;
868 if (m && m->hwgroup && m->hwgroup != new->hwgroup) {
871 printk(KERN_WARNING "%s: potential IRQ problem with %s and %s\n",
872 hwif->name, new->name, m->name);
874 if (!m || m->irq != hwif->irq) /* don't undo a prior perfect match */
877 #endif /* MAX_HWIFS > 1 */
882 static int ide_init_queue(ide_drive_t *drive)
884 struct request_queue *q;
885 ide_hwif_t *hwif = HWIF(drive);
886 int max_sectors = 256;
887 int max_sg_entries = PRD_ENTRIES;
890 * Our default set up assumes the normal IDE case,
891 * that is 64K segmenting, standard PRD setup
892 * and LBA28. Some drivers then impose their own
893 * limits and LBA48 we could raise it but as yet
897 q = blk_init_queue_node(do_ide_request, &ide_lock, hwif_to_node(hwif));
901 q->queuedata = drive;
902 blk_queue_segment_boundary(q, 0xffff);
904 if (hwif->rqsize < max_sectors)
905 max_sectors = hwif->rqsize;
906 blk_queue_max_sectors(q, max_sectors);
909 /* When we have an IOMMU, we may have a problem where pci_map_sg()
910 * creates segments that don't completely match our boundary
911 * requirements and thus need to be broken up again. Because it
912 * doesn't align properly either, we may actually have to break up
913 * to more segments than what was we got in the first place, a max
914 * worst case is twice as many.
915 * This will be fixed once we teach pci_map_sg() about our boundary
916 * requirements, hopefully soon. *FIXME*
918 if (!PCI_DMA_BUS_IS_PHYS)
919 max_sg_entries >>= 1;
920 #endif /* CONFIG_PCI */
922 blk_queue_max_hw_segments(q, max_sg_entries);
923 blk_queue_max_phys_segments(q, max_sg_entries);
925 /* assign drive queue */
928 /* needs drive->queue to be set */
929 ide_toggle_bounce(drive, 1);
934 static void ide_add_drive_to_hwgroup(ide_drive_t *drive)
936 ide_hwgroup_t *hwgroup = drive->hwif->hwgroup;
938 spin_lock_irq(&ide_lock);
939 if (!hwgroup->drive) {
940 /* first drive for hwgroup. */
942 hwgroup->drive = drive;
943 hwgroup->hwif = HWIF(hwgroup->drive);
945 drive->next = hwgroup->drive->next;
946 hwgroup->drive->next = drive;
948 spin_unlock_irq(&ide_lock);
952 * For any present drive:
953 * - allocate the block device queue
954 * - link drive into the hwgroup
956 static void ide_port_setup_devices(ide_hwif_t *hwif)
960 mutex_lock(&ide_cfg_mtx);
961 for (i = 0; i < MAX_DRIVES; i++) {
962 ide_drive_t *drive = &hwif->drives[i];
967 if (ide_init_queue(drive)) {
968 printk(KERN_ERR "ide: failed to init %s\n",
973 ide_add_drive_to_hwgroup(drive);
975 mutex_unlock(&ide_cfg_mtx);
978 static ide_hwif_t *ide_ports[MAX_HWIFS];
980 void ide_remove_port_from_hwgroup(ide_hwif_t *hwif)
982 ide_hwgroup_t *hwgroup = hwif->hwgroup;
984 ide_ports[hwif->index] = NULL;
986 spin_lock_irq(&ide_lock);
988 * Remove us from the hwgroup, and free
989 * the hwgroup if we were the only member
991 if (hwif->next == hwif) {
992 BUG_ON(hwgroup->hwif != hwif);
995 /* There is another interface in hwgroup.
996 * Unlink us, and set hwgroup->drive and ->hwif to
999 ide_hwif_t *g = hwgroup->hwif;
1001 while (g->next != hwif)
1003 g->next = hwif->next;
1004 if (hwgroup->hwif == hwif) {
1005 /* Chose a random hwif for hwgroup->hwif.
1006 * It's guaranteed that there are no drives
1007 * left in the hwgroup.
1009 BUG_ON(hwgroup->drive != NULL);
1012 BUG_ON(hwgroup->hwif == hwif);
1014 spin_unlock_irq(&ide_lock);
1018 * This routine sets up the irq for an ide interface, and creates a new
1019 * hwgroup for the irq/hwif if none was previously assigned.
1021 * Much of the code is for correctly detecting/handling irq sharing
1022 * and irq serialization situations. This is somewhat complex because
1023 * it handles static as well as dynamic (PCMCIA) IDE interfaces.
1025 static int init_irq (ide_hwif_t *hwif)
1027 struct ide_io_ports *io_ports = &hwif->io_ports;
1029 ide_hwgroup_t *hwgroup;
1030 ide_hwif_t *match = NULL;
1032 mutex_lock(&ide_cfg_mtx);
1033 hwif->hwgroup = NULL;
1036 * Group up with any other hwifs that share our irq(s).
1038 for (index = 0; index < MAX_HWIFS; index++) {
1039 ide_hwif_t *h = ide_ports[index];
1041 if (h && h->hwgroup) { /* scan only initialized ports */
1042 if (hwif->irq == h->irq) {
1043 hwif->sharing_irq = h->sharing_irq = 1;
1044 if (hwif->chipset != ide_pci ||
1045 h->chipset != ide_pci) {
1046 save_match(hwif, h, &match);
1049 if (hwif->serialized) {
1050 if (hwif->mate && hwif->mate->irq == h->irq)
1051 save_match(hwif, h, &match);
1053 if (h->serialized) {
1054 if (h->mate && hwif->irq == h->mate->irq)
1055 save_match(hwif, h, &match);
1059 #endif /* MAX_HWIFS > 1 */
1061 * If we are still without a hwgroup, then form a new one
1064 hwgroup = match->hwgroup;
1065 hwif->hwgroup = hwgroup;
1067 * Link us into the hwgroup.
1068 * This must be done early, do ensure that unexpected_intr
1069 * can find the hwif and prevent irq storms.
1070 * No drives are attached to the new hwif, choose_drive
1071 * can't do anything stupid (yet).
1072 * Add ourself as the 2nd entry to the hwgroup->hwif
1073 * linked list, the first entry is the hwif that owns
1074 * hwgroup->handler - do not change that.
1076 spin_lock_irq(&ide_lock);
1077 hwif->next = hwgroup->hwif->next;
1078 hwgroup->hwif->next = hwif;
1079 BUG_ON(hwif->next == hwif);
1080 spin_unlock_irq(&ide_lock);
1082 hwgroup = kmalloc_node(sizeof(*hwgroup), GFP_KERNEL|__GFP_ZERO,
1083 hwif_to_node(hwif));
1084 if (hwgroup == NULL)
1087 hwif->hwgroup = hwgroup;
1088 hwgroup->hwif = hwif->next = hwif;
1090 init_timer(&hwgroup->timer);
1091 hwgroup->timer.function = &ide_timer_expiry;
1092 hwgroup->timer.data = (unsigned long) hwgroup;
1095 ide_ports[hwif->index] = hwif;
1098 * Allocate the irq, if not already obtained for another hwif
1100 if (!match || match->irq != hwif->irq) {
1102 #if defined(__mc68000__)
1104 #endif /* __mc68000__ */
1106 if (hwif->chipset == ide_pci || hwif->chipset == ide_cmd646 ||
1107 hwif->chipset == ide_ali14xx)
1110 if (io_ports->ctl_addr)
1111 hwif->tp_ops->set_irq(hwif, 1);
1113 if (request_irq(hwif->irq,&ide_intr,sa,hwif->name,hwgroup))
1117 if (!hwif->rqsize) {
1118 if ((hwif->host_flags & IDE_HFLAG_NO_LBA48) ||
1119 (hwif->host_flags & IDE_HFLAG_NO_LBA48_DMA))
1122 hwif->rqsize = 65536;
1125 #if !defined(__mc68000__)
1126 printk(KERN_INFO "%s at 0x%03lx-0x%03lx,0x%03lx on irq %d", hwif->name,
1127 io_ports->data_addr, io_ports->status_addr,
1128 io_ports->ctl_addr, hwif->irq);
1130 printk(KERN_INFO "%s at 0x%08lx on irq %d", hwif->name,
1131 io_ports->data_addr, hwif->irq);
1132 #endif /* __mc68000__ */
1134 printk(KERN_CONT " (%sed with %s)",
1135 hwif->sharing_irq ? "shar" : "serializ", match->name);
1136 printk(KERN_CONT "\n");
1138 mutex_unlock(&ide_cfg_mtx);
1141 ide_remove_port_from_hwgroup(hwif);
1143 mutex_unlock(&ide_cfg_mtx);
1147 static int ata_lock(dev_t dev, void *data)
1149 /* FIXME: we want to pin hwif down */
1153 static struct kobject *ata_probe(dev_t dev, int *part, void *data)
1155 ide_hwif_t *hwif = data;
1156 int unit = *part >> PARTN_BITS;
1157 ide_drive_t *drive = &hwif->drives[unit];
1158 if (!drive->present)
1161 if (drive->media == ide_disk)
1162 request_module("ide-disk");
1164 request_module("ide-scsi");
1165 if (drive->media == ide_cdrom || drive->media == ide_optical)
1166 request_module("ide-cd");
1167 if (drive->media == ide_tape)
1168 request_module("ide-tape");
1169 if (drive->media == ide_floppy)
1170 request_module("ide-floppy");
1175 static struct kobject *exact_match(dev_t dev, int *part, void *data)
1177 struct gendisk *p = data;
1178 *part &= (1 << PARTN_BITS) - 1;
1179 return &disk_to_dev(p)->kobj;
1182 static int exact_lock(dev_t dev, void *data)
1184 struct gendisk *p = data;
1191 void ide_register_region(struct gendisk *disk)
1193 blk_register_region(MKDEV(disk->major, disk->first_minor),
1194 disk->minors, NULL, exact_match, exact_lock, disk);
1197 EXPORT_SYMBOL_GPL(ide_register_region);
1199 void ide_unregister_region(struct gendisk *disk)
1201 blk_unregister_region(MKDEV(disk->major, disk->first_minor),
1205 EXPORT_SYMBOL_GPL(ide_unregister_region);
1207 void ide_init_disk(struct gendisk *disk, ide_drive_t *drive)
1209 ide_hwif_t *hwif = drive->hwif;
1210 unsigned int unit = (drive->select.all >> 4) & 1;
1212 disk->major = hwif->major;
1213 disk->first_minor = unit << PARTN_BITS;
1214 sprintf(disk->disk_name, "hd%c", 'a' + hwif->index * MAX_DRIVES + unit);
1215 disk->queue = drive->queue;
1218 EXPORT_SYMBOL_GPL(ide_init_disk);
1220 static void ide_remove_drive_from_hwgroup(ide_drive_t *drive)
1222 ide_hwgroup_t *hwgroup = drive->hwif->hwgroup;
1224 if (drive == drive->next) {
1225 /* special case: last drive from hwgroup. */
1226 BUG_ON(hwgroup->drive != drive);
1227 hwgroup->drive = NULL;
1231 walk = hwgroup->drive;
1232 while (walk->next != drive)
1234 walk->next = drive->next;
1235 if (hwgroup->drive == drive) {
1236 hwgroup->drive = drive->next;
1237 hwgroup->hwif = hwgroup->drive->hwif;
1240 BUG_ON(hwgroup->drive == drive);
1243 static void drive_release_dev (struct device *dev)
1245 ide_drive_t *drive = container_of(dev, ide_drive_t, gendev);
1247 ide_proc_unregister_device(drive);
1249 spin_lock_irq(&ide_lock);
1250 ide_remove_drive_from_hwgroup(drive);
1254 /* Messed up locking ... */
1255 spin_unlock_irq(&ide_lock);
1256 blk_cleanup_queue(drive->queue);
1257 spin_lock_irq(&ide_lock);
1258 drive->queue = NULL;
1259 spin_unlock_irq(&ide_lock);
1261 complete(&drive->gendev_rel_comp);
1264 static int hwif_init(ide_hwif_t *hwif)
1269 hwif->irq = __ide_default_irq(hwif->io_ports.data_addr);
1271 printk(KERN_ERR "%s: disabled, no IRQ\n", hwif->name);
1276 if (register_blkdev(hwif->major, hwif->name))
1279 if (!hwif->sg_max_nents)
1280 hwif->sg_max_nents = PRD_ENTRIES;
1282 hwif->sg_table = kmalloc(sizeof(struct scatterlist)*hwif->sg_max_nents,
1284 if (!hwif->sg_table) {
1285 printk(KERN_ERR "%s: unable to allocate SG table.\n", hwif->name);
1289 sg_init_table(hwif->sg_table, hwif->sg_max_nents);
1291 if (init_irq(hwif) == 0)
1294 old_irq = hwif->irq;
1296 * It failed to initialise. Find the default IRQ for
1297 * this port and try that.
1299 hwif->irq = __ide_default_irq(hwif->io_ports.data_addr);
1301 printk(KERN_ERR "%s: disabled, unable to get IRQ %d\n",
1302 hwif->name, old_irq);
1305 if (init_irq(hwif)) {
1306 printk(KERN_ERR "%s: probed IRQ %d and default IRQ %d failed\n",
1307 hwif->name, old_irq, hwif->irq);
1310 printk(KERN_WARNING "%s: probed IRQ %d failed, using default\n",
1311 hwif->name, hwif->irq);
1314 blk_register_region(MKDEV(hwif->major, 0), MAX_DRIVES << PARTN_BITS,
1315 THIS_MODULE, ata_probe, ata_lock, hwif);
1319 unregister_blkdev(hwif->major, hwif->name);
1323 static void hwif_register_devices(ide_hwif_t *hwif)
1327 for (i = 0; i < MAX_DRIVES; i++) {
1328 ide_drive_t *drive = &hwif->drives[i];
1329 struct device *dev = &drive->gendev;
1332 if (!drive->present)
1335 ide_add_generic_settings(drive);
1337 snprintf(dev->bus_id, BUS_ID_SIZE, "%u.%u", hwif->index, i);
1338 dev->parent = &hwif->gendev;
1339 dev->bus = &ide_bus_type;
1340 dev->driver_data = drive;
1341 dev->release = drive_release_dev;
1343 ret = device_register(dev);
1345 printk(KERN_WARNING "IDE: %s: device_register error: "
1346 "%d\n", __func__, ret);
1350 static void ide_port_init_devices(ide_hwif_t *hwif)
1352 const struct ide_port_ops *port_ops = hwif->port_ops;
1355 for (i = 0; i < MAX_DRIVES; i++) {
1356 ide_drive_t *drive = &hwif->drives[i];
1358 if (hwif->host_flags & IDE_HFLAG_IO_32BIT)
1359 drive->io_32bit = 1;
1360 if (hwif->host_flags & IDE_HFLAG_UNMASK_IRQS)
1362 if (hwif->host_flags & IDE_HFLAG_NO_UNMASK_IRQS)
1363 drive->no_unmask = 1;
1365 if (port_ops && port_ops->init_dev)
1366 port_ops->init_dev(drive);
1370 static void ide_init_port(ide_hwif_t *hwif, unsigned int port,
1371 const struct ide_port_info *d)
1373 hwif->channel = port;
1376 hwif->chipset = d->chipset;
1381 if ((!hwif->irq && (d->host_flags & IDE_HFLAG_LEGACY_IRQS)) ||
1382 (d->host_flags & IDE_HFLAG_FORCE_LEGACY_IRQS))
1383 hwif->irq = port ? 15 : 14;
1385 /* ->host_flags may be set by ->init_iops (or even earlier...) */
1386 hwif->host_flags |= d->host_flags;
1387 hwif->pio_mask = d->pio_mask;
1390 hwif->tp_ops = d->tp_ops;
1392 /* ->set_pio_mode for DTC2278 is currently limited to port 0 */
1393 if (hwif->chipset != ide_dtc2278 || hwif->channel == 0)
1394 hwif->port_ops = d->port_ops;
1396 hwif->swdma_mask = d->swdma_mask;
1397 hwif->mwdma_mask = d->mwdma_mask;
1398 hwif->ultra_mask = d->udma_mask;
1400 if ((d->host_flags & IDE_HFLAG_NO_DMA) == 0) {
1404 rc = d->init_dma(hwif, d);
1406 rc = ide_hwif_setup_dma(hwif, d);
1409 printk(KERN_INFO "%s: DMA disabled\n", hwif->name);
1411 hwif->swdma_mask = 0;
1412 hwif->mwdma_mask = 0;
1413 hwif->ultra_mask = 0;
1414 } else if (d->dma_ops)
1415 hwif->dma_ops = d->dma_ops;
1418 if ((d->host_flags & IDE_HFLAG_SERIALIZE) ||
1419 ((d->host_flags & IDE_HFLAG_SERIALIZE_DMA) && hwif->dma_base)) {
1421 hwif->mate->serialized = hwif->serialized = 1;
1424 if (d->host_flags & IDE_HFLAG_RQSIZE_256)
1427 /* call chipset specific routine for each enabled port */
1432 static void ide_port_cable_detect(ide_hwif_t *hwif)
1434 const struct ide_port_ops *port_ops = hwif->port_ops;
1436 if (port_ops && port_ops->cable_detect && (hwif->ultra_mask & 0x78)) {
1437 if (hwif->cbl != ATA_CBL_PATA40_SHORT)
1438 hwif->cbl = port_ops->cable_detect(hwif);
1442 static ssize_t store_delete_devices(struct device *portdev,
1443 struct device_attribute *attr,
1444 const char *buf, size_t n)
1446 ide_hwif_t *hwif = dev_get_drvdata(portdev);
1448 if (strncmp(buf, "1", n))
1451 ide_port_unregister_devices(hwif);
1456 static DEVICE_ATTR(delete_devices, S_IWUSR, NULL, store_delete_devices);
1458 static ssize_t store_scan(struct device *portdev,
1459 struct device_attribute *attr,
1460 const char *buf, size_t n)
1462 ide_hwif_t *hwif = dev_get_drvdata(portdev);
1464 if (strncmp(buf, "1", n))
1467 ide_port_unregister_devices(hwif);
1468 ide_port_scan(hwif);
1473 static DEVICE_ATTR(scan, S_IWUSR, NULL, store_scan);
1475 static struct device_attribute *ide_port_attrs[] = {
1476 &dev_attr_delete_devices,
1481 static int ide_sysfs_register_port(ide_hwif_t *hwif)
1483 int i, uninitialized_var(rc);
1485 for (i = 0; ide_port_attrs[i]; i++) {
1486 rc = device_create_file(hwif->portdev, ide_port_attrs[i]);
1494 static unsigned int ide_indexes;
1497 * ide_find_port_slot - find free port slot
1500 * Return the new port slot index or -ENOENT if we are out of free slots.
1503 static int ide_find_port_slot(const struct ide_port_info *d)
1506 u8 bootable = (d && (d->host_flags & IDE_HFLAG_NON_BOOTABLE)) ? 0 : 1;
1507 u8 i = (d && (d->host_flags & IDE_HFLAG_QD_2ND_PORT)) ? 1 : 0;;
1510 * Claim an unassigned slot.
1512 * Give preference to claiming other slots before claiming ide0/ide1,
1513 * just in case there's another interface yet-to-be-scanned
1514 * which uses ports 0x1f0/0x170 (the ide0/ide1 defaults).
1516 * Unless there is a bootable card that does not use the standard
1517 * ports 0x1f0/0x170 (the ide0/ide1 defaults).
1519 mutex_lock(&ide_cfg_mtx);
1520 if (MAX_HWIFS == 1) {
1521 if (ide_indexes == 0 && i == 0)
1525 if ((ide_indexes | i) != (1 << MAX_HWIFS) - 1)
1526 idx = ffz(ide_indexes | i);
1528 if ((ide_indexes | 3) != (1 << MAX_HWIFS) - 1)
1529 idx = ffz(ide_indexes | 3);
1530 else if ((ide_indexes & 3) != 3)
1531 idx = ffz(ide_indexes);
1535 ide_indexes |= (1 << idx);
1536 mutex_unlock(&ide_cfg_mtx);
1541 static void ide_free_port_slot(int idx)
1543 mutex_lock(&ide_cfg_mtx);
1544 ide_indexes &= ~(1 << idx);
1545 mutex_unlock(&ide_cfg_mtx);
1548 struct ide_host *ide_host_alloc_all(const struct ide_port_info *d,
1551 struct ide_host *host;
1554 host = kzalloc(sizeof(*host), GFP_KERNEL);
1558 for (i = 0; i < MAX_HWIFS; i++) {
1565 hwif = kzalloc(sizeof(*hwif), GFP_KERNEL);
1569 idx = ide_find_port_slot(d);
1571 printk(KERN_ERR "%s: no free slot for interface\n",
1572 d ? d->name : "ide");
1577 ide_init_port_data(hwif, idx);
1581 host->ports[i] = hwif;
1585 if (host->n_ports == 0) {
1591 host->dev[0] = hws[0]->dev;
1594 host->host_flags = d->host_flags;
1598 EXPORT_SYMBOL_GPL(ide_host_alloc_all);
1600 struct ide_host *ide_host_alloc(const struct ide_port_info *d, hw_regs_t **hws)
1602 hw_regs_t *hws_all[MAX_HWIFS];
1605 for (i = 0; i < MAX_HWIFS; i++)
1606 hws_all[i] = (i < 4) ? hws[i] : NULL;
1608 return ide_host_alloc_all(d, hws_all);
1610 EXPORT_SYMBOL_GPL(ide_host_alloc);
1612 int ide_host_register(struct ide_host *host, const struct ide_port_info *d,
1615 ide_hwif_t *hwif, *mate = NULL;
1618 for (i = 0; i < MAX_HWIFS; i++) {
1619 hwif = host->ports[i];
1626 ide_init_port_hw(hwif, hws[i]);
1627 ide_port_apply_params(hwif);
1634 if ((i & 1) && mate) {
1639 mate = (i & 1) ? NULL : hwif;
1641 ide_init_port(hwif, i & 1, d);
1642 ide_port_cable_detect(hwif);
1643 ide_port_init_devices(hwif);
1646 for (i = 0; i < MAX_HWIFS; i++) {
1647 hwif = host->ports[i];
1652 if (ide_probe_port(hwif) == 0)
1655 if (hwif->chipset != ide_4drives || !hwif->mate ||
1656 !hwif->mate->present)
1657 ide_register_port(hwif);
1660 ide_port_tune_devices(hwif);
1663 for (i = 0; i < MAX_HWIFS; i++) {
1664 hwif = host->ports[i];
1669 if (hwif_init(hwif) == 0) {
1670 printk(KERN_INFO "%s: failed to initialize IDE "
1671 "interface\n", hwif->name);
1679 ide_port_setup_devices(hwif);
1681 ide_acpi_init(hwif);
1684 ide_acpi_port_init_devices(hwif);
1687 for (i = 0; i < MAX_HWIFS; i++) {
1688 hwif = host->ports[i];
1693 if (hwif->chipset == ide_unknown)
1694 hwif->chipset = ide_generic;
1697 hwif_register_devices(hwif);
1700 for (i = 0; i < MAX_HWIFS; i++) {
1701 hwif = host->ports[i];
1706 ide_sysfs_register_port(hwif);
1707 ide_proc_register_port(hwif);
1710 ide_proc_port_register_devices(hwif);
1715 EXPORT_SYMBOL_GPL(ide_host_register);
1717 int ide_host_add(const struct ide_port_info *d, hw_regs_t **hws,
1718 struct ide_host **hostp)
1720 struct ide_host *host;
1723 host = ide_host_alloc(d, hws);
1727 rc = ide_host_register(host, d, hws);
1729 ide_host_free(host);
1738 EXPORT_SYMBOL_GPL(ide_host_add);
1740 void ide_host_free(struct ide_host *host)
1745 for (i = 0; i < MAX_HWIFS; i++) {
1746 hwif = host->ports[i];
1751 ide_free_port_slot(hwif->index);
1757 EXPORT_SYMBOL_GPL(ide_host_free);
1759 void ide_host_remove(struct ide_host *host)
1763 for (i = 0; i < MAX_HWIFS; i++) {
1765 ide_unregister(host->ports[i]);
1768 ide_host_free(host);
1770 EXPORT_SYMBOL_GPL(ide_host_remove);
1772 void ide_port_scan(ide_hwif_t *hwif)
1774 ide_port_apply_params(hwif);
1775 ide_port_cable_detect(hwif);
1776 ide_port_init_devices(hwif);
1778 if (ide_probe_port(hwif) < 0)
1783 ide_port_tune_devices(hwif);
1784 ide_acpi_port_init_devices(hwif);
1785 ide_port_setup_devices(hwif);
1786 hwif_register_devices(hwif);
1787 ide_proc_port_register_devices(hwif);
1789 EXPORT_SYMBOL_GPL(ide_port_scan);
1791 static void ide_legacy_init_one(hw_regs_t **hws, hw_regs_t *hw,
1792 u8 port_no, const struct ide_port_info *d,
1793 unsigned long config)
1795 unsigned long base, ctl;
1808 if (!request_region(base, 8, d->name)) {
1809 printk(KERN_ERR "%s: I/O resource 0x%lX-0x%lX not free.\n",
1810 d->name, base, base + 7);
1814 if (!request_region(ctl, 1, d->name)) {
1815 printk(KERN_ERR "%s: I/O resource 0x%lX not free.\n",
1817 release_region(base, 8);
1821 ide_std_init_ports(hw, base, ctl);
1823 hw->chipset = d->chipset;
1824 hw->config = config;
1829 int ide_legacy_device_add(const struct ide_port_info *d, unsigned long config)
1831 hw_regs_t hw[2], *hws[] = { NULL, NULL, NULL, NULL };
1833 memset(&hw, 0, sizeof(hw));
1835 if ((d->host_flags & IDE_HFLAG_QD_2ND_PORT) == 0)
1836 ide_legacy_init_one(hws, &hw[0], 0, d, config);
1837 ide_legacy_init_one(hws, &hw[1], 1, d, config);
1839 if (hws[0] == NULL && hws[1] == NULL &&
1840 (d->host_flags & IDE_HFLAG_SINGLE))
1843 return ide_host_add(d, hws, NULL);
1845 EXPORT_SYMBOL_GPL(ide_legacy_device_add);