]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/blob - drivers/gpu/drm/drm_drawable.c
drm: fix leak of cliprects in drm_rmdraw()
[linux-2.6-omap-h63xx.git] / drivers / gpu / drm / drm_drawable.c
1 /**
2  * \file drm_drawable.c
3  * IOCTLs for drawables
4  *
5  * \author Rickard E. (Rik) Faith <faith@valinux.com>
6  * \author Gareth Hughes <gareth@valinux.com>
7  * \author Michel Dänzer <michel@tungstengraphics.com>
8  */
9
10 /*
11  * Created: Tue Feb  2 08:37:54 1999 by faith@valinux.com
12  *
13  * Copyright 1999 Precision Insight, Inc., Cedar Park, Texas.
14  * Copyright 2000 VA Linux Systems, Inc., Sunnyvale, California.
15  * Copyright 2006 Tungsten Graphics, Inc., Bismarck, North Dakota.
16  * All Rights Reserved.
17  *
18  * Permission is hereby granted, free of charge, to any person obtaining a
19  * copy of this software and associated documentation files (the "Software"),
20  * to deal in the Software without restriction, including without limitation
21  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
22  * and/or sell copies of the Software, and to permit persons to whom the
23  * Software is furnished to do so, subject to the following conditions:
24  *
25  * The above copyright notice and this permission notice (including the next
26  * paragraph) shall be included in all copies or substantial portions of the
27  * Software.
28  *
29  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
30  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
31  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
32  * VA LINUX SYSTEMS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
33  * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
34  * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
35  * OTHER DEALINGS IN THE SOFTWARE.
36  */
37
38 #include "drmP.h"
39
40 /**
41  * Allocate drawable ID and memory to store information about it.
42  */
43 int drm_adddraw(struct drm_device *dev, void *data, struct drm_file *file_priv)
44 {
45         unsigned long irqflags;
46         struct drm_draw *draw = data;
47         int new_id = 0;
48         int ret;
49
50 again:
51         if (idr_pre_get(&dev->drw_idr, GFP_KERNEL) == 0) {
52                 DRM_ERROR("Out of memory expanding drawable idr\n");
53                 return -ENOMEM;
54         }
55
56         spin_lock_irqsave(&dev->drw_lock, irqflags);
57         ret = idr_get_new_above(&dev->drw_idr, NULL, 1, &new_id);
58         if (ret == -EAGAIN) {
59                 spin_unlock_irqrestore(&dev->drw_lock, irqflags);
60                 goto again;
61         }
62
63         spin_unlock_irqrestore(&dev->drw_lock, irqflags);
64
65         draw->handle = new_id;
66
67         DRM_DEBUG("%d\n", draw->handle);
68
69         return 0;
70 }
71
72 /**
73  * Free drawable ID and memory to store information about it.
74  */
75 int drm_rmdraw(struct drm_device *dev, void *data, struct drm_file *file_priv)
76 {
77         struct drm_draw *draw = data;
78         unsigned long irqflags;
79         struct drm_drawable_info *info;
80
81         spin_lock_irqsave(&dev->drw_lock, irqflags);
82
83         info = drm_get_drawable_info(dev, draw->handle);
84         drm_free(info->rects, info->num_rects * sizeof(struct drm_clip_rect),
85                         DRM_MEM_BUFS);
86         drm_free(info, sizeof(struct drm_drawable_info), DRM_MEM_BUFS);
87
88         idr_remove(&dev->drw_idr, draw->handle);
89
90         spin_unlock_irqrestore(&dev->drw_lock, irqflags);
91         DRM_DEBUG("%d\n", draw->handle);
92         return 0;
93 }
94
95 int drm_update_drawable_info(struct drm_device *dev, void *data, struct drm_file *file_priv)
96 {
97         struct drm_update_draw *update = data;
98         unsigned long irqflags;
99         struct drm_clip_rect *rects;
100         struct drm_drawable_info *info;
101         int err;
102
103         info = idr_find(&dev->drw_idr, update->handle);
104         if (!info) {
105                 info = drm_calloc(1, sizeof(*info), DRM_MEM_BUFS);
106                 if (!info)
107                         return -ENOMEM;
108                 if (IS_ERR(idr_replace(&dev->drw_idr, info, update->handle))) {
109                         DRM_ERROR("No such drawable %d\n", update->handle);
110                         drm_free(info, sizeof(*info), DRM_MEM_BUFS);
111                         return -EINVAL;
112                 }
113         }
114
115         switch (update->type) {
116         case DRM_DRAWABLE_CLIPRECTS:
117                 if (update->num == 0)
118                         rects = NULL;
119                 else if (update->num != info->num_rects) {
120                         rects = drm_alloc(update->num * sizeof(struct drm_clip_rect),
121                                          DRM_MEM_BUFS);
122                 } else
123                         rects = info->rects;
124
125                 if (update->num && !rects) {
126                         DRM_ERROR("Failed to allocate cliprect memory\n");
127                         err = -ENOMEM;
128                         goto error;
129                 }
130
131                 if (update->num && DRM_COPY_FROM_USER(rects,
132                                                      (struct drm_clip_rect __user *)
133                                                      (unsigned long)update->data,
134                                                      update->num *
135                                                      sizeof(*rects))) {
136                         DRM_ERROR("Failed to copy cliprects from userspace\n");
137                         err = -EFAULT;
138                         goto error;
139                 }
140
141                 spin_lock_irqsave(&dev->drw_lock, irqflags);
142
143                 if (rects != info->rects) {
144                         drm_free(info->rects, info->num_rects *
145                                  sizeof(struct drm_clip_rect), DRM_MEM_BUFS);
146                 }
147
148                 info->rects = rects;
149                 info->num_rects = update->num;
150
151                 spin_unlock_irqrestore(&dev->drw_lock, irqflags);
152
153                 DRM_DEBUG("Updated %d cliprects for drawable %d\n",
154                           info->num_rects, update->handle);
155                 break;
156         default:
157                 DRM_ERROR("Invalid update type %d\n", update->type);
158                 return -EINVAL;
159         }
160
161         return 0;
162
163 error:
164         if (rects != info->rects)
165                 drm_free(rects, update->num * sizeof(struct drm_clip_rect),
166                          DRM_MEM_BUFS);
167
168         return err;
169 }
170
171 /**
172  * Caller must hold the drawable spinlock!
173  */
174 struct drm_drawable_info *drm_get_drawable_info(struct drm_device *dev, drm_drawable_t id)
175 {
176         return idr_find(&dev->drw_idr, id);
177 }
178 EXPORT_SYMBOL(drm_get_drawable_info);
179
180 static int drm_drawable_free(int idr, void *p, void *data)
181 {
182         struct drm_drawable_info *info = p;
183
184         if (info) {
185                 drm_free(info->rects, info->num_rects *
186                          sizeof(struct drm_clip_rect), DRM_MEM_BUFS);
187                 drm_free(info, sizeof(*info), DRM_MEM_BUFS);
188         }
189
190         return 0;
191 }
192
193 void drm_drawable_free_all(struct drm_device *dev)
194 {
195         idr_for_each(&dev->drw_idr, drm_drawable_free, NULL);
196         idr_remove_all(&dev->drw_idr);
197 }